Skip to content

Fix remote host empty state fixture width - #334339

Merged
Henning Dieterichs (hediet) merged 1 commit into
mainfrom
hediet/fix-remote-host-fixture-width
Sep 3, 2026
Merged

Fix remote host empty state fixture width#334339
Henning Dieterichs (hediet) merged 1 commit into
mainfrom
hediet/fix-remote-host-fixture-width

Conversation

@hediet

Copy link
Copy Markdown
Member

Summary

  • give the remote host empty-state fixture a deterministic width
  • define the centered-content CSS variable inherited by the rendered component

Validation

  • rendered all 8 Dark/Light fixture variants without errors
  • verified the fixture measures 950x240
  • verified the screenshot is stable across 3 mounts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ce266339-31ab-4cfb-a049-5b65fea0c7c8
Copilot AI balanced review requested due to automatic review settings September 3, 2026 18:27
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Some pipeline(s) encountered errors during trigger evaluation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused fixture change correctly reuses the production width constant and introduces no unresolved issues.

Review tier: Balanced
Findings: None

What changed in this PR

Makes remote-host empty-state fixtures deterministic and consistent with Sessions layout sizing.

Changes:

  • Sets the fixture width from the shared 950px layout constant.
  • Defines the inherited centered-content CSS variable.
File Description
src/​vs/​sessions/​test/​browser/​remoteHostUnavailableEmptyState.fixture.ts Stabilizes fixture dimensions and centered-content styling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 3d7dfbdb Current: c0855379

3 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (8)

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Dark

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Light

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Dark

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Light

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Dark

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Light

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Dark

current

sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Light

current

@hediet
Henning Dieterichs (hediet) merged commit f64b8bd into main Sep 3, 2026
41 checks passed
@hediet
Henning Dieterichs (hediet) deleted the hediet/fix-remote-host-fixture-width branch September 3, 2026 19:05
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants