sessions: Add no-workspace option to new session picker - #334356
Merged
Megan Rogge (meganrogge) merged 7 commits intoSep 3, 2026
Merged
sessions: Add no-workspace option to new session picker#334356Megan Rogge (meganrogge) merged 7 commits into
Megan Rogge (meganrogge) merged 7 commits into
Conversation
Offer a workspace-less quick chat from the Agents Window workspace picker when consolidated remote workspaces are enabled, while preserving the existing picker presentation and safely cancelling pending workspace drafts.\n\nFixes #334345\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the option available for an existing workspace-less draft, but do not offer it when no provider can create quick chats.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 3, 2026 19:27
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The onboarding tour cannot advance when a first-run user selects the valid No workspace option.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/newChatWidget.ts — This setting now also controls whether the picker remains visible for quick chats and whether **No… |
|
src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts — The option is absent when no provider supports quick chats, but this help text says it is always… |
What changed in this PR
Adds workspace-less quick-chat selection to the Agents Window’s consolidated workspace picker.
Changes:
- Adds and presents a selectable No workspace option.
- Cancels pending workspace creation and prevents stale workspace feedback context.
- Adds accessibility guidance and unit tests.
| File | Description |
|---|---|
sessionWorkspacePicker.ts |
Adds option rendering and selection presentation. |
newChatWidget.ts |
Creates and manages workspace-less drafts. |
sessionsChatAccessibilityHelp.ts |
Documents the new picker option. |
sessionWorkspacePicker.test.ts |
Tests consolidated-picker selection. |
newChatWidget.test.ts |
Tests availability, cancellation, and workspace roots. |
Suppressed comments (1)
src/vs/sessions/contrib/chat/browser/newChatWidget.ts:470
- This makes the workspace onboarding step eligible for quick-chat drafts, but that step hides Next and advances only when
SessionHasWorkspaceContextbecomes true (newSessionViewTourShared.ts:24-35). Selecting the newly valid No workspace option leaves that key false, so first-run users cannot complete the step without choosing a workspace. Update the tour to also advance forIsQuickChatSessionContext(and adjust its copy/tests).
this._workspacePickerVisibleKey.set(!isQuickChat || useConsolidatedPicker);
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 3, 2026 19:41
Contributor
|
Base:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 85ad2220-1132-4b10-86b1-266e38e2ba29
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
I don't know why the screenshot changed (the css must have changed in a very subtle way), I believe you can just update the hash. |
Paul (pwang347)
approved these changes
Sep 3, 2026
Megan Rogge (meganrogge)
deleted the
agents/consolidated-remote-workspaces-setting
branch
September 3, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334345
Adds a No workspace option to the Agents Window new-session workspace picker when
chat.agentSessions.consolidatedRemoteWorkspacesis enabled. The existing picker presentation, grouping, and Automations picker remain unchanged.Selecting the option creates a workspace-less quick-chat draft, cancels pending workspace creation, and avoids carrying the previous workspace into feedback formatting. The option is shown only when a provider supports quick chats, while remaining available for an already-active workspace-less draft.
Testing
npm run compilenpm run hygiene./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts --run src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts(91 passing)