build: override product Copilot runtime - #334648
Merged
Merged
Conversation
Update the bundled root and remote dependencies to the requested canary builds. Accept the SDK's policyHelper managed-settings source in diagnostics and E2E validation.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore the public Copilot dependency pins used by OSS builds. Product builds can apply the requested private-feed SDK and CLI canaries through the existing Azure pipeline override parameters.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a checked-in manifest as the default source for Copilot SDK and CLI versions in Azure product builds while keeping OSS package manifests on public versions. Retain queue-time selectors as recovery and validation escape hatches.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the OSS SDK version and check in the product runtime canary as the existing Azure pipeline parameter default. Extend the shared override path to support runtime-only updates.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Both product pipelines default to a runtime package that is not yet available on the private feed.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: None
What changed in this PR
Updates product builds to override only the Copilot runtime while retaining the OSS SDK version, and recognizes the runtime’s new managed-settings diagnostics source.
Changes:
- Adds runtime-only authenticated dependency overrides.
- Pins product builds to the requested runtime canary.
- Accepts
policyHelperdiagnostics.
| File | Description |
|---|---|
build/azure-pipelines/product-build.yml |
Sets the product runtime default. |
build/azure-pipelines/product-build-ado-ci.yml |
Mirrors the runtime default for ADO CI. |
build/azure-pipelines/common/apply-sdk-canary.yml |
Runs overrides for SDK or runtime changes. |
build/azure-pipelines/common/apply-sdk-canary-override.ts |
Supports independent dependency overrides. |
src/vs/platform/agentHost/common/agent.ts |
Adds the diagnostics source type. |
src/vs/platform/agentHost/test/node/e2e/suites/managementExtensionsSuite.ts |
Accepts the new source in E2E validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the existing sdk-canary build tag emission scoped to latest-canary resolution while adding runtime-only overrides.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Set the checked-in product runtime override to 1.0.84-canary.67.g6496fad.unsigned.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
September 5, 2026 02:06
roblourens
enabled auto-merge (squash)
September 5, 2026 02:06
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Vritant Bhardwaj (vritant24)
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@github/copilotand@github/copilot-sdkversions1.0.84-canary.67.g6496fad.unsignedas the default product@github/copilotruntime versionpolicyHelpermanaged-settings diagnostics sourceImplementation
The existing
VSCODE_CLI_CANARY_VERSIONparameter remains the product-build override mechanism, but its checked-in default is now the desired runtime canary.VSCODE_SDK_CANARY_VERSIONstaysnone, so product builds retain the SDK from the OSS manifest. The shared pre-cache step now runs when either override is present and refreshes only the dependency that changed.Validation
cd build && npm run typechecknpm run typecheck-clientnpm run hygieneThe requested
1.0.84-canary.67.g6496fad.unsignedpackage is not yet visible on the private feed, so an Azure product build with that exact runtime cannot succeed until it is published.Main-branch counterpart of #334649.
(Written by Copilot)