eslint: fix bracket notation in build scripts - #334766
Open
Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Open
eslint: fix bracket notation in build scripts#334766Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Conversation
Enable code-no-bracket-notation-for-identifiers for JavaScript and TypeScript files while grandfathering the 509 files with existing violations in a CODEOWNERS-gated allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Organize the existing baseline by feature area so cleanup can be tracked and assigned without changing the excluded file set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add RuleTester coverage for valid accesses, diagnostics, and autofix edge cases. Preserve escaped string-literal property names by checking their raw source before reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use dot notation for identifier-like properties across build, CI, and script tooling, then remove the 48 cleaned files from the baseline allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 6, 2026 20:59
View session
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 6, 2026 21:00
Dmitriy Vasyura (dmitrivMS)
requested a review
from Alexandru Dima (alexdima)
as a code owner
September 6, 2026 21:00
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 6, 2026 21:00
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mechanical conversions preserve property keys and the cleaned files no longer require the ESLint allowlist entries.
Review tier: Balanced
Findings: None
What changed in this PR
Updates build, CI, and utility scripts for the bracket-notation ESLint rule introduced by #334756 without changing runtime behavior.
Changes:
- Replaces identifier-like bracket access with dot notation across 48 files.
- Removes those files from the ESLint grandfathering allowlist.
| File | Description |
|---|---|
.eslint-allowed-bracket-notation-files |
Removes 48 cleaned paths. |
scripts/test-agent-host-e2e.ts |
Updates environment access. |
scripts/sync-agent-host-protocol.ts |
Updates environment access. |
scripts/code-web.js |
Updates parsed argument access. |
scripts/code-sessions-web.js |
Updates parsed argument access. |
scripts/code-server.js |
Updates environment and argument access. |
scripts/code-agent-host.js |
Updates environment access. |
build/win32/explorer-dll-fetcher.ts |
Updates architecture environment access. |
build/rspack/rspack.serve-out.config.mts |
Updates environment access. |
build/npm/update-localization-extension.ts |
Updates package metadata access. |
build/npm/preinstall.ts |
Updates environment access. |
build/npm/postinstall.ts |
Updates installation environment access. |
build/linux/libcxx-fetcher.ts |
Updates build environment access. |
build/linux/debian/install-sysroot.ts |
Updates environment and sysroot metadata access. |
build/lib/test/render.test.ts |
Updates translation-module access. |
build/lib/preLaunch.ts |
Updates environment access. |
build/lib/policies/exportPolicyData.ts |
Updates export environment access. |
build/lib/i18n.ts |
Updates parsed XML and environment access. |
build/lib/getVersion.ts |
Updates build-version access. |
build/lib/fetch.ts |
Updates CI environment access. |
build/lib/electron.ts |
Updates token access. |
build/lib/compilation.ts |
Updates source-map flag access. |
build/lib/builtInExtensions.ts |
Updates build environment access. |
build/hygiene.ts |
Updates CI environment access. |
build/gulpfile.vscode.win32.ts |
Updates definition and product access. |
build/gulpfile.vscode.ts |
Updates CI environment access. |
build/gulpfile.vscode.linux.ts |
Updates strip-tool access. |
build/gulpfile.reh.ts |
Updates glibc environment access. |
build/darwin/verify-macho.ts |
Updates application-path access. |
build/darwin/sign.ts |
Updates signing environment access. |
build/darwin/sign-server.ts |
Updates signing environment access. |
build/darwin/create-universal-app.ts |
Updates architecture access. |
build/darwin/create-dmg.ts |
Updates build environment access. |
build/azure-pipelines/win32/codesign.ts |
Updates pipeline environment access. |
build/azure-pipelines/upload-sourcemaps.ts |
Updates Azure credential access. |
build/azure-pipelines/upload-nlsmetadata.ts |
Updates Azure credential access. |
build/azure-pipelines/upload-cdn.ts |
Updates Azure credential access. |
build/azure-pipelines/oss/scan-licenses.ts |
Updates parsed argument access. |
build/azure-pipelines/oss/merge-notices.ts |
Updates parsed argument access. |
build/azure-pipelines/oss/audit-notices.ts |
Updates parsed argument access. |
build/azure-pipelines/distro/mixin-quality.ts |
Updates environment and extension access. |
build/azure-pipelines/common/sign.ts |
Updates signing credential access. |
build/azure-pipelines/common/sign-win32.ts |
Updates signing-tool access. |
build/azure-pipelines/common/releaseBuild.ts |
Updates database endpoint access. |
build/azure-pipelines/common/publish.ts |
Updates JWS header access. |
build/azure-pipelines/common/getPublishAuthTokens.ts |
Updates Azure credential access. |
build/azure-pipelines/common/downloadNotice.ts |
Updates feature-flag access. |
build/azure-pipelines/common/createBuild.ts |
Updates build and Azure environment access. |
build/azure-pipelines/common/apply-sdk-canary-override.ts |
Updates canary-version access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslint-allowed-bracket-notation-filesThis PR is intentionally stacked on #334756, which enables
local/code-no-bracket-notation-for-identifiers. Its base should be changed tomainafter #334756 merges.Validation
--max-warnings=0across all 48 cleaned filesnpm run typecheckfrombuildgit diff --check