Keep IPC sockets in tmp#91931
Closed
roblourens wants to merge 1 commit into
Closed
Conversation
joaomoreno
reviewed
Apr 3, 2020
joaomoreno
left a comment
joaomoreno
left a comment
Contributor
There was a problem hiding this comment.
While I understand the idea, I am not comfortable with this:
- This area is prone to bad stuff. Really bad stuff. Some people will have weird stuff in their tmpdir. Ie network paths which do not support named pipes.
- There is no guarantee that tmpdir will result in a smaller path than user data dir
Member
Author
|
If you're not comfortable with it, I'm not comfortable with it. How about I check the length and log a warning if it's too long but leave the logic alone |
Contributor
|
Yeah that would be already much better than today 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #86382