Remove VS Code extension from repo#615
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the WinApp VS Code extension from the winappcli monorepo now that it has moved to a dedicated repository, and cleans up build/CI/docs references so the remaining CLI + npm + NuGet + MSIX workflows continue to function without extension artifacts.
Changes:
- Deleted the entire VS Code extension project under
src/winapp-VSC/(source, tests, fixtures, configs, and build tooling). - Removed VS Code extension packaging/release scripts and CI/pipeline artifact handling for
.vsix. - Updated top-level docs and build guidance to describe CLI-based debugging/identity workflows instead of extension-based F5 flows.
Reviewed changes
Copilot reviewed 71 out of 74 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/winapp-VSC/tsconfig.json | Deleted VS Code extension TypeScript config. |
| src/winapp-VSC/src/winapp-cli-utils.ts | Deleted extension helper for locating bundled winapp.exe. |
| src/winapp-VSC/src/test/xml-utils.test.ts | Deleted manifest-editor XML utility unit tests. |
| src/winapp-VSC/src/test/redos-prevention.test.ts | Deleted ReDoS-prevention unit test for manifest validation. |
| src/winapp-VSC/src/test/fixtures/winui-gallery.appxmanifest | Deleted extension E2E/unit fixture manifest. |
| src/winapp-VSC/src/test/fixtures/widgets-sample.appxmanifest | Deleted extension E2E/unit fixture manifest. |
| src/winapp-VSC/src/test/fixtures/push-notifications-sample.appxmanifest | Deleted extension E2E/unit fixture manifest. |
| src/winapp-VSC/src/test/fixtures/edge-cases.appxmanifest | Deleted adversarial parsing fixture manifest. |
| src/winapp-VSC/src/test/fixtures/background-task-sample.appxmanifest | Deleted extension E2E/unit fixture manifest. |
| src/winapp-VSC/src/test/extension-templates.test.ts | Deleted template/round-trip unit tests for extension manifest editor. |
| src/winapp-VSC/src/test/extension-field-validator.test.ts | Deleted field-validator unit tests for extension editor. |
| src/winapp-VSC/src/test/e2e/shared-context.ts | Deleted Playwright shared VS Code instance harness. |
| src/winapp-VSC/src/test/e2e/resources-tab.spec.ts | Deleted Playwright E2E spec for Resources tab. |
| src/winapp-VSC/src/test/e2e/README.md | Deleted extension E2E test documentation. |
| src/winapp-VSC/src/test/e2e/push-notifications-fixture.spec.ts | Deleted Playwright E2E spec for push notifications fixture. |
| src/winapp-VSC/src/test/e2e/properties-tab.spec.ts | Deleted Playwright E2E spec for Properties tab. |
| src/winapp-VSC/src/test/e2e/parse-error.spec.ts | Deleted Playwright E2E spec for malformed XML handling. |
| src/winapp-VSC/src/test/e2e/mrt-validation.spec.ts | Deleted Playwright E2E spec for MRT validation behavior. |
| src/winapp-VSC/src/test/e2e/identity-tab.spec.ts | Deleted Playwright E2E spec for Identity tab. |
| src/winapp-VSC/src/test/e2e/helpers.ts | Deleted Playwright helpers (launch, webview frame access, interactions). |
| src/winapp-VSC/src/test/e2e/global-teardown.ts | Deleted Playwright global teardown for shared VS Code instance. |
| src/winapp-VSC/src/test/e2e/editor-launch.spec.ts | Deleted Playwright E2E spec for editor launch/navigation. |
| src/winapp-VSC/src/test/e2e/dependencies-tab.spec.ts | Deleted Playwright E2E spec for Dependencies tab. |
| src/winapp-VSC/src/test/e2e/capabilities-tab.spec.ts | Deleted Playwright E2E spec for Capabilities tab. |
| src/winapp-VSC/src/manifest-editor/webview-script-resources.ts | Deleted webview JS resource-tab script chunk. |
| src/winapp-VSC/src/manifest-editor/webview-script-identity.ts | Deleted webview JS identity-tab script chunk. |
| src/winapp-VSC/src/manifest-editor/webview-script-dependencies.ts | Deleted webview JS dependencies-tab script chunk. |
| src/winapp-VSC/src/manifest-editor/webview-script-capabilities.ts | Deleted webview JS capabilities-tab script chunk. |
| src/winapp-VSC/src/manifest-editor/manifest-xml-ops-applications.ts | Deleted manifest XML ops for applications/extensions (extension editor). |
| src/winapp-VSC/README.md | Deleted extension README and usage docs from this repo. |
| src/winapp-VSC/playwright.config.ts | Deleted Playwright config for extension E2E suite. |
| src/winapp-VSC/package.json | Deleted extension package.json contribution points (commands, debuggers, custom editor). |
| src/winapp-VSC/eslint.config.mjs | Deleted extension ESLint config. |
| src/winapp-VSC/esbuild.mjs | Deleted extension build bundler script. |
| src/winapp-VSC/.vscodeignore | Deleted VSIX packaging ignore list. |
| src/winapp-VSC/.vscode/tasks.json | Deleted extension dev tasks. |
| src/winapp-VSC/.vscode/launch.json | Deleted extension debug launch config. |
| scripts/start-vsc-release.ps1 | Deleted VS Code extension release-branch automation script. |
| scripts/setup-winapprun.ps1 | Removed .vsix install step; keeps MSIX + local NuGet feed setup. |
| scripts/package-vsc.ps1 | Deleted VSIX packaging script. |
| scripts/build-cli.ps1 | Removed -SkipVsc flag and the VSIX packaging step. |
| README.md | Removed VS Code extension download links/section; updated build description accordingly. |
| docs/dotnet-run-support.md | Removed -SkipVsc mention from build-script docs. |
| docs/debugging.md | Replaced extension-based debug workflow with CLI-based identity + standard debugger attach configs. |
| .vscode/settings.json | Removed extension-project-specific exclude settings. |
| .pipelines/templates/build.yaml | Removed VSIX artifact copy/upload steps from Azure Pipelines template. |
| .pipelines/release-vsc.yml | Deleted the VS Code extension release pipeline. |
| .gitignore | Removed VS Code extension testing ignore rules and *.vsix ignore entry. |
| .github/workflows/test-samples.yml | Removed -SkipVsc from the CI build step. |
| .github/workflows/post-metrics-comment.yml | Dropped VSIX artifact size reporting and artifact mapping. |
| .github/workflows/build-package.yml | Removed VSIX artifact upload from the build/package workflow. |
| .github/skills/pr-review/SKILL.md | Removed src/winapp-VSC/ from PR-review “area ownership” guidance. |
| .github/skills/pr-review/dimensions/security.md | Removed VS Code extension mention from security dimension context. |
| .github/skills/pr-review/dimensions/packaging.md | Removed VS Code extension artifact/parity notes from packaging dimension. |
| .github/skills/pr-review/dimensions/docs-and-samples.md | Removed VS Code extension label guidance from docs/samples dimension. |
| .github/actions/collect-metrics/action.yml | Removed .vsix size measurement from metrics collection action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+205
to
207
| # 2. Local NuGet feed for BuildTools.MSIX.Extras | ||
| # ═══════════════════════════════════════════════════════════════════════════════ | ||
| Write-Step "Setting up local NuGet feed for BuildTools.MSIX.Extras" |
chiaramooney
force-pushed
the
chiaramooney/remove-vsc-extension
branch
2 times, most recently
from
3ffc408 to
db0f301
Compare
The WinApp VS Code extension has moved to its own repository, so this removes all extension source, tests, docs, and references from this repo: - Delete src/winapp-VSC/ (extension source, tests, fixtures, assets) - Delete scripts/package-vsc.ps1 and scripts/start-vsc-release.ps1 - Delete .pipelines/release-vsc.yml - Drop VSC packaging step and -SkipVsc flag from scripts/build-cli.ps1 - Drop .vsix artifact upload/metrics from CI workflows and pipeline template - Remove VSC install step from scripts/setup-winapprun.ps1 - Update README, docs/debugging.md (keep generic attach workflow via CLI), docs/dotnet-run-support.md, and pr-review skill docs - Clean up .gitignore and .vscode/settings.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e1c79d8b-df06-4f0d-b773-cb51dc413b61
chiaramooney
force-pushed
the
chiaramooney/remove-vsc-extension
branch
from
db0f301 to
92fcf48
Compare
Contributor
Build Metrics ReportBinary Sizes
Test Results✅ 1545 passed, 1 skipped out of 1546 tests in 408.6s (-77.7s vs. baseline) Test Coverage❌ 18% line coverage, 37.2% branch coverage · CLI Startup Time40ms median (x64, Updated 2026-07-10 22:29:07 UTC · commit |
nmetulev
approved these changes
Jul 11, 2026
nmetulev
added a commit
that referenced
this pull request
Jul 11, 2026
Resolve conflicts from #615 (VS Code extension removed from repo): the 5 modified src/winapp-VSC/src/test/fixtures/*.appxmanifest files were deleted on main, so accept the deletion. PackageIntegrity additions to the surviving samples, CLI templates, and CLI test-app manifests are retained. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WinApp VS Code extension has moved to its own repository, so it's no longer needed here. This PR removes all extension source, tests, docs, and references from this repo.
Changes
Deleted (58 files)
src/winapp-VSC/— the entire extension: source, manifest editor, unit + e2e tests, fixtures, assets, and configscripts/package-vsc.ps1andscripts/start-vsc-release.ps1.pipelines/release-vsc.ymlBuild & CI
-SkipVscparameter fromscripts/build-cli.ps1.vsixartifact upload and size metrics frombuild-package.yml,post-metrics-comment.yml,collect-metrics/action.yml, and.pipelines/templates/build.yaml-SkipVsccall fromtest-samples.yml.vsixinstall step fromscripts/setup-winapprun.ps1Docs
README.md— removed the VS Code Extension section and download linksdocs/debugging.md— replaced the extension's F5 /winappdebug-type section with an equivalent CLI-based workflow (winapp create-debug-identity, standard attach configs,winapp unregister) so the debugging guide stays usefuldocs/dotnet-run-support.mdand thepr-reviewskill docs — removed extension mentions.gitignoreand.vscode/settings.jsonVerification
git grepconfirms zero remaining VS Code extension references (remaining "VS Code" mentions are legitimate editor/debugger references, not the extension)