Add #[flags] attribute support to windows-rdl for System.FlagsAttribute - #3965
Merged
Kenny Kerr (kennykerr) merged 2 commits intoMar 10, 2026
Merged
Conversation
Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add handling for System.Flags in windows-rdl
Add Mar 10, 2026
#[flags] attribute support to windows-rdl for System.FlagsAttribute
Kenny Kerr (kennykerr)
marked this pull request as ready for review
March 10, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.FlagsAttributeis a CLS-defined attribute that won't appear in RDL definitions, but is encoded in ECMA-335 metadata like any other custom attribute. The RDL reader and writer had no awareness of it.Reader (RDL →
.winmd)#[flags]on an enum is now a built-in RDL keyword (likerepr): skipped by the generic attribute resolver and encoded directly as aSystem.FlagsAttributecustom attribute on the enum'sTypeDef#[flags]takes no argumentsWriter (
.winmd→ RDL)System.FlagsAttribute(by namespace + name) on enums and emits#[flags]in the RDL output after#[repr(...)]FlagsAttributefrom the generic attribute pass to prevent incorrect emission as#[System::Flags]Tests
enum-flags.rdl/enum-flags.rs) using theVirtualKeyModifiersexample from the issue#[flags(args)](flags takes no arguments)Original prompt
windows-rdldoesn't handleSystem.Flags#3964🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.