Remove redundant test_standalone and tool_standalone crates - #4101
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3adfcab7-ab17-4b8d-b25c-f6e33caf08c8 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kenny Kerr (kennykerr)
March 28, 2026 02:05
View session
Kenny Kerr (kennykerr)
marked this pull request as ready for review
March 28, 2026 02:05
Collaborator
|
Copilot you need to update the gen.yml workflow to remove the test. |
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3ec30c94-8ca1-41dc-b318-fe8b965dee39 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_standaloneandtool_standaloneare fully superseded bytest_bindgenand the broader test suite. Removes them to reduce CI time.Why they're redundant:
test_standalone(--sys,--flat,--no-deps,--vtbl,--derive) is already covered bytest_bindgenmodules (bool_sys,struct_sys/win,interface_cpp_sys,derive_struct,struct_arch_a/w, etc.)CoCreateGuid,SysAllocString,Uri::CreateUri,Calendar::new(), etc.) are covered bytest_core,test_strings, and thewinrt/cratestool_standalone/src/main.rsalready carried// TODO: move these into the new bindgen test/toolRemoved:
crates/tests/misc/standalone/— 33 pre-generatedb_*.rsbinding files + runtime tests (~4,100 lines)crates/tools/standalone/— the regeneration tool that produced those files (~260 lines)test.ymlandclippy.ymlviacargo run -p tool_ymlstandalonefrom thetoolmatrix in.github/workflows/gen.ymlCI savings: 4 steps removed per platform × 5 platforms = 20 fewer invocations per run (test + clippy, for both
test_standaloneandtool_standalone), plus thegen.ymlmatrix is reduced by one entry.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.