windows-rdl / clang: propget support - #4243
Merged
Kenny Kerr (kennykerr) merged 5 commits intoApr 21, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/945d860e-c748-419a-9159-fda0a9f878ed Co-authored-by: riverar <475132+riverar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add propget support to clang crate
windows-rdl / clang: propget support
Apr 21, 2026
| /// Verifies that a pure-virtual method preceded by a `/* ... [propget] ... */` | ||
| /// block comment emits `#[special]`, while methods with no such comment do not. | ||
| #[test] | ||
| fn propget() { |
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/60887bf4-ceed-4ca7-ac1d-8fe06a684beb Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Collaborator
|
Copilot Check out my comments above. |
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/ec04bae7-cf41-4431-8213-edc6eff00582 Co-authored-by: riverar <475132+riverar@users.noreply.github.com>
Rafael Rivera (riverar)
approved these changes
Apr 21, 2026
Kenny Kerr (kennykerr)
marked this pull request as ready for review
April 21, 2026 20:13
Kenny Kerr (kennykerr)
approved these changes
Apr 21, 2026
Kenny Kerr (kennykerr)
deleted the
copilot/add-propget-support-clarification
branch
April 21, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COM virtual methods annotated with
[propget]in their MIDL-generated block comment now emit#[special]in the generated RDL.Before:
After:
Changes
clang/interface.rs— AddedMethodModifiersstruct withMethodModifiers::from_tokens()that scans the method's token stream up to (not past) the function name, detecting[propget]in anyCXToken_Commenttoken. TheMethodModifiersdoc comment now accurately describes these as MIDL attributes, noting thatpropgetindicates a property accessor function.InterfaceMethodgains anis_propgetfield;write()emits#[special]when set.roundtrip/propget.h/propget.rdl— New roundtrip golden test covering a method with[propget], one with an unrelated comment, and one with no comment.