Unwrap MIDL-synthesised anonymous enum names into top-level constants - #4273
Merged
Rafael Rivera (riverar) merged 2 commits intoApr 23, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/b33d82fd-9ae8-4d7b-b264-0d6bfa0c488f Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix anonymous enumeration unwrapping for Windows RDL
Unwrap MIDL-synthesised anonymous enum names into top-level constants
Apr 23, 2026
Rafael Rivera (riverar)
approved these changes
Apr 23, 2026
Rafael Rivera (riverar)
marked this pull request as ready for review
April 23, 2026 21:54
Rafael Rivera (riverar)
deleted the
copilot/unwrap-anonymous-enumeration
branch
April 23, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIDL assigns synthetic tag names (e.g.
__MIDL___MIDL_itf_dia2_0000_0000_0001) to enumerations that were anonymous in the original IDL. The clang parser was treating these as named enums instead of unwrapping their variants as top-level constants.cx.rs: Addedis_midl_anonymous_enum_name()— returnstruefor names starting with__MIDL_, the prefix MIDL uses for all synthesised anonymous-type names.mod.rs: Extended the anonymous-enum check to also cover MIDL-synthesised names, so their variants are emitted as top-level RDL constants (same path as truly unnamedenum { ... }).roundtrip/midl_enum.{h,rdl}: New roundtrip golden test exercising the fix.Before:
After: