Phase 4 batch 3: drop writer_errors.rs happy-path duplicates - #4350
Merged
Kenny Kerr (kennykerr) merged 2 commits intoApr 30, 2026
Conversation
…date test-todo.md Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/98c11952-390f-47d4-97c1-dd756a1afe26 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/98c11952-390f-47d4-97c1-dd756a1afe26 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kenny Kerr (kennykerr)
April 30, 2026 18:47
View session
Kenny Kerr (kennykerr)
marked this pull request as ready for review
April 30, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the test consolidation in
docs/test-todo.md. The fourwriter_succeeds_for_*smoke tests incrates/tests/libs/rdl/tests/writer_errors.rsonly assertresult.is_ok()on RDL inputs that are strict subsets of existing roundtrip fixtures, which already prove the same writer paths via byte-stable diffs.writer_errors.rs: removed the 4 happy-path tests (195 → 107 lines / 6 → 2 tests). Header comment records the rationale and the per-case mapping to legacy fixtures.compile_rdl_to_winmdstays (still used bywriter_split_returns_err_for_bad_output_dir); bothwriter_returns_err_for_*tests stay — they exercise filesystem I/O failures the harness doesn't yet model.docs/test-todo.md: added Phase 4 "Batch 3" subsection with the per-fixture mapping (callback→fn.rdl, delegate→delegate.rdl, enum→enum.rdl, interface→class.rdl/event-interface.rdl); recorded the new rule "migration may be a deletion when an existing fixture already covers the inputs"; updated the deferred table forwriter_errors.rsto reflect what remains.Migration outcome here is deletion rather than fixture conversion — converting these would only churn files that phase 5 would delete anyway.