Run most of test_future on Linux - #4359
Merged
Kenny Kerr (kennykerr) merged 2 commits intoMay 1, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3c6b164a-3d99-4fe9-98ea-f76b1c11c19b Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kenny Kerr (kennykerr)
May 1, 2026 03:10
View session
Collaborator
|
Copilot check build |
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/f568b4fd-76de-4461-8efb-c44e54445567 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Contributor
Author
Kenny Kerr (kennykerr)
marked this pull request as ready for review
May 1, 2026 12:38
Kenny Kerr (kennykerr)
deleted the
copilot/investigate-test-future-exclusion
branch
May 1, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of
test_futurewas excluded on non-Windows via a blanket#![cfg(windows)]even though most tests only exercise the stockwindows-futureasync implementations, which are pure Rust apart from one internalWaiterand a thread-pool dispatch that already had non-Windows paths.windows-futurecfg(all(not(windows), feature = "std"))Waiter/WaiterSignalerbacked byArc<(Mutex<bool>, Condvar)>soIAsyncAction::join()works off-Windows.bindings_impl(rawlink!decls forCreateEventW/SetEvent/WaitForSingleObject/CloseHandleandHANDLE/BOOL/...) behind#[cfg(windows)].stdfeature now also enableswindows-threading/stdso thestd::thread::spawnfallback forsubmitis actually pulled in.test_futureuse windows::core::*/use windows::Win32::Foundation::*withuse windows_core::*plus inlineconst HRESULTdefinitions forE_FAIL,E_ILLEGAL_DELEGATE_ASSIGNMENT,E_ILLEGAL_METHOD_CALL,E_PROTOCOL_EXTENSIONS_NOT_SUPPORTED(matches the existing pattern intest_collections). TheE_FAILconstant inwhen.rsis gated#[cfg(windows)]to match its only consumer (theerrtest).#![cfg(windows)]fromagile,async_info,completed_finished,completed_get,completed_once,completed_started,dropped,progress,started,when, and the emptysrc/lib.rs.futures.rs— uses Win32ThreadPooland WinRTStorage::Streams.error.rsandwhen::err— assert onError::message(), which only round-trips message text on Windows (viaIErrorInfo/OriginateError).windows-coreto dev-dependencies.Result on Linux
10 of 12 test binaries now run; 29 cross-platform tests pass. Windows behavior is unchanged — every new branch is gated by
#[cfg(windows)]/#[cfg(all(not(windows), feature = "std"))].