Skip to content

Remove --no-allow and --no-comment options from windows-bindgen - #4441

Merged
Kenny Kerr (kennykerr) merged 5 commits into
masterfrom
copilot/remove-no-allow-no-comment-options
May 20, 2026
Merged

Remove --no-allow and --no-comment options from windows-bindgen#4441
Kenny Kerr (kennykerr) merged 5 commits into
masterfrom
copilot/remove-no-allow-no-comment-options

Conversation

Copilot AI commented May 20, 2026

Copy link
Copy Markdown
Contributor

Remove the --no-allow and --no-comment options from windows-bindgen entirely.

  • Remove CLI flags / builder methods / Config fields; stop emitting banner + #![allow(...)]
  • Strip the options from all .txt/build.rs/fixture.toml call sites
  • Remove no_allow/no_comment from the fixtures harness; delete obsolete fixtures
  • Regenerate library bindings (cargo run -p tool_bindings)
  • Add outer #[allow(non_snake_case, …)] to mod bindings; declarations that needed it
  • Regenerate rdl tests' src/{fn_abi,struct_fields,struct_values}.rs and add outer #[allow(…)] in crates/tests/libs/rdl/src/lib.rs
  • Update docs (options.md, data/README.md)
  • cargo test -p test_rdl
  • cargo test -p test_bindgen --test fixtures
  • cargo fmt --all --check
  • Open PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants