Remove --no-allow and --no-comment options from windows-bindgen - #4441
Merged
Kenny Kerr (kennykerr) merged 5 commits intoMay 20, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/c30d79f7-ff71-4470-a656-4c0a60f3197b Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kenny Kerr (kennykerr)
May 20, 2026 04:59
View session
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/3474a284-2742-4173-9509-ce6e908d33cb Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/b13d5ca0-ce26-4fb9-8a0e-3c27a2274e75 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Kenny Kerr (kennykerr)
marked this pull request as ready for review
May 20, 2026 10:50
Kenny Kerr (kennykerr)
deleted the
copilot/remove-no-allow-no-comment-options
branch
May 20, 2026 10:50
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
--no-allowand--no-commentoptions fromwindows-bindgenentirely.Configfields; stop emitting banner +#![allow(...)].txt/build.rs/fixture.tomlcall sitesno_allow/no_commentfrom the fixtures harness; delete obsolete fixturescargo run -p tool_bindings)#[allow(non_snake_case, …)]tomod bindings;declarations that needed it#[allow(…)]incrates/tests/libs/rdl/src/lib.rsoptions.md,data/README.md)cargo test -p test_rdl✅cargo test -p test_bindgen --test fixtures✅cargo fmt --all --check✅