Simplify windows-bindgen internals: Step C smaller leftovers - #4451
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/355f1b92-3681-45a2-b966-e1debc7099bd Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Kenny Kerr (kennykerr)
May 20, 2026 20:02
View session
Kenny Kerr (kennykerr)
marked this pull request as ready for review
May 20, 2026 20:18
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #4450 by picking off Step C ("smaller leftovers") from
docs/bindgen.md.Option.Bindgen::rustfmtandBindgen::linkare nowOption<String>(andConfig::rustfmtisOption<&str>), replacing the """means default" sentinel with a plainOptionmatch inBindgen::writeandformat.rs.input/filter/derive/referenceare one-lineself.<plural>(std::iter::once(x))wrappers; the plural forms remain the single source of truth.prepend_default_refsrewritten. n×Vec::insert(0, …)→ onesplice(0..0, paths.iter().rev().map(…)). Single O(n) shift;.rev()reproduces the historical ordering that repeatedinsert(0, …)produced.--etcdocumented. Added to the supported-arguments table incrates/libs/bindgen/src/lib.rs; the response-file feature used bycrates/tools/bindingsis no longer undocumented.docs/bindgen.mdtrimmed. Section C removed and dropped from the suggested order of attack, leaving Steps A (mergeBindgen/Config) and B (splitconfig/) as the remaining work.No public API or behaviour changes.