windows-bindgen remove variant overrides - #4747
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes previously hard-coded bindgen overrides by switching D2D_VECTOR_3F to the existing Numerics remap path and deleting now-redundant VARIANT/PROPVARIANT special-casing in bindgen’s struct codegen. This aligns Win32 projection output with the established Windows.Foundation.Numerics substitutions used throughout the windows crate.
Changes:
- Remove the locally-defined
D2D_VECTOR_3FWin32 struct from thewindowscrate projection output. - Add a bindgen remap from
D2D_VECTOR_3F->Windows.Foundation.Numerics.Vector3(matching existing Vector2/Vector4 behavior). - Delete unused
VARIANT/PROPVARIANToverrides and constants in bindgen codegen.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/libs/windows/src/Windows/Win32/dcommon/mod.rs | Drops the D2D_VECTOR_3F struct definition from the Win32 projection output. |
| crates/libs/bindgen/src/types/mod.rs | Adds D2D_VECTOR_3F -> Windows.Foundation.Numerics.Vector3 remap alongside existing Numerics substitutions. |
| crates/libs/bindgen/src/types/cpp_struct.rs | Removes VARIANT/PROPVARIANT special-case logic in clone/copyability decisions. |
| crates/libs/bindgen/src/type_name.rs | Removes now-unused TypeName::VARIANT and TypeName::PROPVARIANT constants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are no longer required.