Skip to content

New version: axpnet.AeroFTP version 4.1.6#407642

Merged
microsoft-github-policy-service[bot] merged 2 commits into
microsoft:masterfrom
axpnet:axpnet.AeroFTP-4.1.6-E8117080E47D43598D748CF4A9B48304
Jul 25, 2026
Merged

New version: axpnet.AeroFTP version 4.1.6#407642
microsoft-github-policy-service[bot] merged 2 commits into
microsoft:masterfrom
axpnet:axpnet.AeroFTP-4.1.6-E8117080E47D43598D748CF4A9B48304

Conversation

@axpnet

@axpnet axpnet commented Jul 25, 2026 •
edited by microsoft-github-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Pull request has been created with WinGet Releaser 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot

wingetbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-148-407642-20260725-1

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 25, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Author-Feedback This needs a response from the author. Validation-Guide Something happened during validation. Provide the guide. labels Jul 25, 2026
@wingetbot

wingetbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-148-407642-20260725-2

@axpnet

axpnet commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Fixed — the duplicate entry is gone and the correct installer pair is restored.

The installer.yaml carried two identical Installers entries for the same _x64-setup.exe, differing only by InstallerSwitches, which is not part of the installer identity tuple (architecture / type / scope / locale) — hence DuplicateInstallerEntry.

Root cause on our side: the release workflow was passing installers-regex: '_x64-setup\.exe$', so WinGet Releaser handed komac a single asset while the previously published manifest (4.1.5) declares two installers. komac builds the new version on the shape of the previous one, found two installer slots and one matching asset, and filled both slots with it. Same thing had happened at 4.1.5 in #402974.

The manifest is now regenerated with komac 2.16.0 against both released assets and matches the shape of the merged 4.1.5 manifest: x64 nullsoft scope user (AeroFTP_4.1.6_x64-setup.exe) plus x64 wix scope machine (AeroFTP_4.1.6_x64_en-US.msi, per-version ProductCode {1004E8CB-B433-4BBB-9B0C-A93737A925EE}, stable UpgradeCode {3A660390-AA69-5CCD-A202-013C64158D37}). This also keeps the machine-scope upgrade path working for users who installed from the MSI.

The workflow regex is being widened to cover both assets in the same pass, so this cannot recur at the next release.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 25, 2026
axpnet added a commit to axpdev-lab/aeroftp that referenced this pull request Jul 25, 2026
@axpnet @claude
ci(winget): publish both installers so komac stops duplicating the exe
7bd78cc 
installers-regex was narrowed to the x64 setup exe in a597007 to dodge a
then-failing WinGet wix validation lane, but the previously published manifest
still declared two installers (x64 NSIS user-scope, x64 WiX machine-scope).
komac builds a new version on the shape of the previous one, so it found two
installer slots and one matching asset and filled both slots with that asset,
producing two byte-identical entries differing only by InstallerSwitches, which
is not part of the installer identity tuple. WinGet rejected it as
DuplicateInstallerEntry: at 4.1.5 in microsoft/winget-pkgs#402974, which was
worked around by regenerating the manifest by hand, and again at 4.1.6 in
microsoft/winget-pkgs#407642.

The wix lane is no longer failing: 4.1.5 merged clean with the MSI on
2026-07-19. Restoring the msi to the publish makes the two installer slots
legitimate again, keeps the machine-scope upgrade path alive for users who
installed from the MSI, and removes the need for a manual komac run per release.
The regex now matches exactly the two release assets that back those slots.

The 4.1.6 manifest on the open PR has been regenerated to the same shape.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@axpnet axpnet mentioned this pull request Jul 25, 2026
Open
3 tasks
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 25, 2026
@microsoft-github-policy-service
microsoft-github-policy-service Bot enabled auto-merge (squash) July 25, 2026 08:16
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Validation-Guide Something happened during validation. Provide the guide. label Jul 25, 2026
@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 25, 2026
@microsoft-github-policy-service
microsoft-github-policy-service Bot merged commit 9aaad2c into microsoft:master Jul 25, 2026
1 check passed
@wingetbot

wingetbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes
@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axpnet @wingetbot @stephengillie