Skip to content

feat(optim): show custom operator domains - #1306

Merged
xieofxie merged 2 commits into
mainfrom
hualxie/optim_show_domain
Aug 14, 2026
Merged

feat(optim): show custom operator domains#1306
xieofxie merged 2 commits into
mainfrom
hualxie/optim_show_domain

Conversation

@xieofxie

Copy link
Copy Markdown
Contributor

Summary

  • preserve ONNX node domains in optimization analysis results
  • qualify non-default-domain operators in --check-optim output, such as com.microsoft::Gelu
  • include custom domains in structured optimization-output data while keeping default ONNX operator output unchanged

Validation

  • uv run pytest tests/unit/optim/test_analysis.py tests/unit/commands/test_optimize_cli.py tests/unit/analyze/test_optim_output.py
  • uv run ruff check --fix src/winml/modelkit/optim/analysis.py src/winml/modelkit/analyze/optim_output.py tests/unit/optim/test_analysis.py tests/unit/commands/test_optimize_cli.py tests/unit/analyze/test_optim_output.py

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@xieofxie
xieofxie requested a review from a team as a code owner August 13, 2026 02:54

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the domain propagation through graph collection, diff reporting, CLI rendering, structured optimization output, and produced-operator support. The implementation is backward compatible for default-domain ONNX nodes and all CI checks pass. No blocking findings.

Comment thread src/winml/modelkit/optim/analysis.py
Comment thread src/winml/modelkit/optim/analysis.py
Comment thread src/winml/modelkit/analyze/optim_output.py
Comment thread src/winml/modelkit/analyze/optim_output.py
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Re-reviewed the latest head. The added test locks down backward-compatible serialization for the explicit ai.onnx domain, custom-domain propagation remains correct, and all CI checks pass.

@xieofxie
xieofxie merged commit 9cedf7f into main Aug 14, 2026
9 checks passed
@xieofxie
xieofxie deleted the hualxie/optim_show_domain branch August 14, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants