Skip to content

Add Windows build details to winml sys - #1387

Merged
xieofxie merged 4 commits into
mainfrom
hualxie/sys
Sep 2, 2026
Merged

Add Windows build details to winml sys#1387
xieofxie merged 4 commits into
mainfrom
hualxie/sys

Conversation

@xieofxie

@xieofxie xieofxie commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • read detailed Windows version metadata from the native CurrentVersion registry key
  • include product, display version, build, UBR, branch, and build lab values in text and JSON output
  • tolerate missing registry keys or individual values
  • document the additional output and add unit coverage
image

hualxie and others added 2 commits September 2, 2026 14:20
hualxie
Add Windows build details to winml sys
4570430 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hualxie
Merge remote-tracking branch 'origin/main' into hualxie/sys
3231ce0
@xieofxie
xieofxie requested a review from a team as a code owner September 2, 2026 06:32
hualxie
Fix Windows platform metadata typing
23b2513 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
DingmaomaoBJTU
Qiong Wu (qiowu) (DingmaomaoBJTU) reviewed Sep 2, 2026
View reviewed changes
Comment thread src/winml/modelkit/commands/sys.py Outdated
hualxie
Remove unreliable Windows product name
0c0a171 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@xieofxie
xieofxie merged commit 8d631f6 into main Sep 2, 2026
9 checks passed
@xieofxie
xieofxie deleted the hualxie/sys branch September 2, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DingmaomaoBJTU Qiong Wu (qiowu) (DingmaomaoBJTU) DingmaomaoBJTU approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xieofxie @DingmaomaoBJTU