Skip to content

fix model precision for qdq#753

Merged
xieofxie merged 1 commit into
release/v0.1.0from
hualxie/qdq_fix_0.1.0
May 27, 2026
Merged

fix model precision for qdq#753
xieofxie merged 1 commit into
release/v0.1.0from
hualxie/qdq_fix_0.1.0

Conversation

@xieofxie
Copy link
Copy Markdown
Contributor

No description provided.

@xieofxie xieofxie requested a review from a team as a code owner May 26, 2026 08:27
@DingmaomaoBJTU
Copy link
Copy Markdown
Collaborator

Code review

Found 1 issue:

  1. Stale _get_precision docstring: the PR changes _label() to always return w{w_bits}a{a_bits} format, so "int4", "int8", "int16" can no longer be returned for QDQ paths. However, the docstring still lists them as possible return values. The io_config property docstring also references "int8" as an example.

Returns one of: ``"fp32"``, ``"fp16"``, ``"bf16"``, ``"int4"``,
``"int8"``, ``"int16"``, ``"w{w}a{a}"`` (mixed), or ``None`` when
no signal can be derived.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@xieofxie xieofxie merged commit a4b2c32 into release/v0.1.0 May 27, 2026
9 checks passed
@xieofxie xieofxie deleted the hualxie/qdq_fix_0.1.0 branch May 27, 2026 00:55
@xieofxie
Copy link
Copy Markdown
Contributor Author

Code review

Found 1 issue:

  1. Stale _get_precision docstring: the PR changes _label() to always return w{w_bits}a{a_bits} format, so "int4", "int8", "int16" can no longer be returned for QDQ paths. However, the docstring still lists them as possible return values. The io_config property docstring also references "int8" as an example.

Returns one of: ``"fp32"``, ``"fp16"``, ``"bf16"``, ``"int4"``,
``"int8"``, ``"int16"``, ``"w{w}a{a}"`` (mixed), or ``None`` when
no signal can be derived.

🤖 Generated with Claude Code

  • If this code review was useful, please react with 👍. Otherwise, react with 👎.

Will fix later

timenick added a commit that referenced this pull request May 27, 2026
…757)

## Summary

- Folds the seven fixes merged after the v0.1.0 release notes into the
existing v0.1.0 changelog section: #745, #746 (inspect), #747, #753
(perf), #750 (eval), #744/#752, #754 (analyze/compile e2e).
- Trims the v0.1.0 section to focus on user-visible changes:
  - Removed telemetry mentions (#728 preview bullet and #693 fix line).
- Removed pure-internal CI/test items (CI display name rename, ADO
pipeline UI plumbing, mock fixes, branch back-merge).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants