update windows build container#106
Merged
Merged
Conversation
Contributor
Author
|
FYI, this change will get picked up as part of the new Sunday night build container refresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing seperate install of Windows 10 SDK. As of 15.9.1, VS Build Tools includes Windows 10 SDK v17763 (aka RS5 SDK). Verified manually that this new image works with our existing build infrastrucutre
Note, the WIndows SDK is a required depenency of the cmake tooling (aka Microsoft.VisualStudio.Component.VC.CMake.Project). I think we should be specifying the Windows SDK on the build tools command line, but the docs are unclear on the topic. Waiting on feedback from VS team before committing.VS team verified Windows 10 SDK v17763 component ID is same between VS and VS Build Tools, though it's not listed on the VS Build tool component ID list page (currently). Manually added to dockerfile to ensure correct installation in case vs build tool dependency tree changes in the future