Skip to content

C++/WinRT improved capture helpers and variadic delegates#114

Merged
kennykerr merged 5 commits into
masterfrom
kennykerr
Jan 3, 2019
Merged

C++/WinRT improved capture helpers and variadic delegates#114
kennykerr merged 5 commits into
masterfrom
kennykerr

Conversation

@kennykerr

@kennykerr kennykerr commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

This update fixes the limitation with the winrt::capture helpers by supporting projected types as well. The comes up now and then with the WinRT interop APIs when they return a projected type.

This update also adds support for get_strong/get_weak when creating a variadic winrt::delegate.

I have also ported the original capture tests from cppwinrt and fixed some minor issues building xlang with VS 2019.

Issues: #113, #112

Comment thread src/library/impl/base.h
#include <list>
#include <map>
#include <optional>
#include <string>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xlang libraries use std::to_string, which is included with <string>.

@Scottj1s Scottj1s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kennykerr kennykerr merged commit 16da417 into master Jan 3, 2019
@kennykerr kennykerr deleted the kennykerr branch January 10, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants