C++/WinRT coroutine locals may return/complete before locals are destroyed#116
Merged
Conversation
GorNishanov
reviewed
Jan 8, 2019
GorNishanov
suggested changes
Jan 8, 2019
Contributor
|
Independent of anything specific to this PR, can I just say how much I appreciate @GorNishanov's feedback! |
…g cannot forward braces).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JamesMcNellis recently discovered that the traditional way of implementing a coroutine type may allow locals within the coroutine to be destroyed after the coroutine returns/completes (rather than prior to final suspension). @GorNishanov clarified that the resumption of any waiter should be deferred until final suspension to avoid this problem (among other benefits).
This update fixes this problem for C++/WinRT coroutines and also ports over all of the existing coroutine tests from out internal repo. New tests have been added to detect this issue as well.
I wish I could port over VSO's vastly superior PR viewer as well. 🙁