Fix C++/WinRT override class code gen#123
Merged
Merged
Conversation
Contributor
Author
|
Completing this PR as it resolves a build break (caused by the MIDL regression) that's preventing me from completing the other approved PR... 🙄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, C++/WinRT would not generate the appropriate using declarations to disambiguate overloads of required interfaces. This is now fixed and the resulting user override can now call those base members.
Beyond that, this update includes some minor code gen formatting tweaks as well as a workaround for another MIDLRT regression related to attributes.