Improve C++/WinRT compat with Xaml projects#140
Merged
Merged
Conversation
Scottj1s
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that Xaml projects are a source of questionable metadata and cppwinrt needs to be a little more resilient for compatibility. Previously, cppwinrt allowed for activatable runtime classes that didn't declare a default interface. This was never supposed to happen but MIDLRT mistakenly allowed it, so we need to maintain this accommodation for now. Also, some build configurations for Xaml projects will mistakenly end up feeding xppwinrt winmds with overlapping types. The cppwinrt compiler has to ignore dupes on the assumption that the types are identical.