Cmake before 3.11 requires a source argument#145
Merged
Conversation
kennykerr
approved these changes
Jan 25, 2019
Contributor
|
Had to manually kick off PR builds due to mis-configuration of xlang's AzDO pipelines. PR validation from external forks should kick off automatically now. UPDATE manual PR build failed as I don't apparently know how to trigger a PR validation build from an external repo. Still digging |
Contributor
|
@CaptainZippy can you push a trivial whitespace change to this PR in an attempt to kick off the PR validation? |
Contributor
|
I'm going to go ahead and merge this w/o validation builds. I setup my own xlang fork and submitted a test PR to ensure forked repo PR builds were working. I made the same change @CaptainZippy made, and it built fine. |
Contributor
|
THanks for your PR @CaptainZippy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.