made options a constexpr array, removed unused lib & root#165
Merged
Conversation
DefaultRyan
approved these changes
Feb 8, 2019
kennykerr
reviewed
Feb 9, 2019
| w.write_root_include("base"); | ||
| auto format = R"(% | ||
| bool WINRT_CALL %_can_unload_now() noexcept | ||
| bool WINRT_CALL winrt_can_unload_now() noexcept |
Contributor
There was a problem hiding this comment.
No, this is wrong. It's very important that this preamble to these functions is still configurable.
kennykerr
reviewed
Feb 9, 2019
| } | ||
|
|
||
| void* WINRT_CALL %_get_activation_factory(std::wstring_view const& name) | ||
| void* WINRT_CALL winrt_get_activation_factory(std::wstring_view const& name) |
kennykerr
reviewed
Feb 9, 2019
| #endif | ||
|
|
||
| return %_can_unload_now() ? 0 : 1; | ||
| return winrt_can_unload_now() ? 0 : 1; |
kennykerr
reviewed
Feb 9, 2019
| std::wstring_view const name{ buffer, length }; | ||
|
|
||
| *factory = %_get_activation_factory(name); | ||
| *factory = winrt_get_activation_factory(name); |
kennykerr
reviewed
Feb 9, 2019
| { "help", 0, cmd::option::no_max, {}, "Show detailed help with examples" }, | ||
| { "root", 0, 1 }, // "Root folder name for projection headers (defaults to winrt) | ||
| { "filter" }, // One or more prefixes to include in input (same as -include) | ||
| { "lib", 0, 1 }, // Specify library prefix (defaults to winrt) |
Contributor
There was a problem hiding this comment.
I'll fix this up. I forgot the lib prefix applies to those module exports. It's critical that they can be changed to allow multiple libs to be combined into a single DLL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.