Skip to content

Python/WinRT Assorted Fixes#196

Merged
devhawk merged 21 commits into
masterfrom
devhawk/pyfixes
Mar 5, 2019
Merged

Python/WinRT Assorted Fixes#196
devhawk merged 21 commits into
masterfrom
devhawk/pyfixes

Conversation

@devhawk

@devhawk devhawk commented Mar 1, 2019

Copy link
Copy Markdown
Contributor
  • Manage PyObject* lifetimes with RAII wrappers
  • add dealloc functions for structs and winrt_base
  • rework native await function for IAsync* types to better match original Python implementation
  • fix array view construction for pass_array parameters
  • rework how root module name is accessed in the projection generation code
  • add module name to projected types
  • Update python tests to include generated folder in search path
  • Remove explicit init apartment calls from python tests
  • remove explicit debug flags (/Zi and /Od) from setup.py

Example generated code available: https://github.com/devhawk/pywinrt-output/pull/6/files

@devhawk devhawk requested review from Scottj1s and zooba March 1, 2019 22:25
Comment thread src/tool/python/strings/pybase.h

@Scottj1s Scottj1s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@devhawk

devhawk commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

fixes #191

@devhawk

devhawk commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

fixes #104

@devhawk

devhawk commented Mar 5, 2019

Copy link
Copy Markdown
Contributor Author

https://github.com/devhawk/pywinrt-output/pull/6/files updated w/ latest projected code

@devhawk devhawk merged commit d22f79f into master Mar 5, 2019
@devhawk devhawk deleted the devhawk/pyfixes branch March 6, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants