Skip to content

Remove fixed size buffer when reading lines from the response file.#206

Merged
kennykerr merged 4 commits into
microsoft:masterfrom
jlaanstra:jlaans/fix-line-limitation
Mar 7, 2019
Merged

Remove fixed size buffer when reading lines from the response file.#206
kennykerr merged 4 commits into
microsoft:masterfrom
jlaanstra:jlaans/fix-line-limitation

Conversation

@jlaanstra

Copy link
Copy Markdown
Contributor

This PR removes a hardcoded maximum line length and instead, dynamically allocates a string to read lines.

Currently cppwinrt.exe silently fails. @kennykerr thoughts on outputting some kind of error when the response file contains invalid data?

@kennykerr

Copy link
Copy Markdown
Contributor

You can report errors using throw_invalid().

@jlaanstra

Copy link
Copy Markdown
Contributor Author

Looks like that might be handled already as it hits the same code path as if it was passed in without a response file.

Comment thread src/library/cmd_reader.h Outdated
@kennykerr kennykerr merged commit 8e0faf8 into microsoft:master Mar 7, 2019
@kennykerr

Copy link
Copy Markdown
Contributor

Thanks Johan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants