Remove fixed size buffer when reading lines from the response file.#206
Merged
Merged
Conversation
Contributor
|
You can report errors using |
Contributor
Author
|
Looks like that might be handled already as it hits the same code path as if it was passed in without a response file. |
Scottj1s
reviewed
Mar 7, 2019
Scottj1s
approved these changes
Mar 7, 2019
kennykerr
approved these changes
Mar 7, 2019
Contributor
|
Thanks Johan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a hardcoded maximum line length and instead, dynamically allocates a string to read lines.
Currently cppwinrt.exe silently fails. @kennykerr thoughts on outputting some kind of error when the response file contains invalid data?