Phase 1 of cppxlang tool. Duplicate cppwinrt.#213
Merged
Conversation
DefaultRyan
requested review from
BenJKuhn,
Scottj1s,
devhawk and
kennykerr
as code owners
kennykerr
approved these changes
Mar 8, 2019
DefaultRyan
force-pushed
the
defaultryan/cppx
branch
from
e7f6745 to
1988b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll be doing the cppxlang compiler in phases, to avoid overwhelming reviewers with unmanageable diffs. This first phase is the wholesale copying of the cppwinrt tool sources into the cppxlang tool. Note that nothing in the code is changed yet - you can diff the two directories yourselves to verify. The only real difference is CMakeLists.txt.
Future phases will highlight diffs that diverge from cppwinrt (including removal of some functionality and coalescing common logic).