XDN11 - Xlang Error handling#235
Merged
Merged
Conversation
manodasanW
requested review from
BenJKuhn,
BrentRe,
DefaultRyan,
Scottj1s,
devhawk and
kennykerr
jonwis
suggested changes
Mar 26, 2019
jonwis
left a comment
jonwis
left a comment
Member
There was a problem hiding this comment.
Handful of suggested changes and comments in the PR. Looks like a reasonable - if Windows-centric - direction. Curious how this plays out on Python-to-Rust on Linux, for instance.
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
devhawk
reviewed
Mar 28, 2019
kennykerr
reviewed
Apr 3, 2019
kennykerr
reviewed
Apr 3, 2019
bbowman
reviewed
Apr 3, 2019
devhawk
suggested changes
Apr 3, 2019
devhawk
reviewed
Apr 3, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
reviewed
Apr 12, 2019
Scottj1s
approved these changes
Apr 17, 2019
devhawk
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the intial draft of the xlang error handling design note. Please leave any feedback.