cppxlang able to compile against clang/linux#242
Merged
Conversation
DefaultRyan
requested review from
BenJKuhn,
Scottj1s,
devhawk and
kennykerr
as code owners
jonwis
approved these changes
Mar 23, 2019
kennykerr
reviewed
Mar 23, 2019
kennykerr
approved these changes
Mar 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to redirect some of the guts from Windows to the PAL, so you can't do anything interesting without hitting link errors on clang/Linux.
But at least it's compiling cleanly now, so this is a good checkpoint to get some of this work checked in while I continue with more of the migration.