MethodDef::Params() should return a pair of iterators#244
Merged
Conversation
…tors All collection methods return a pair of iterators, with the exception of `MethodDef::Params()`. Make it act like all the others for consistency. Otherwise, consumers have to write a range specialization just for this one case.
Member
Author
|
|
oldnewthing
requested review from
BenJKuhn,
Scottj1s and
devhawk
as code owners
DefaultRyan
approved these changes
Mar 24, 2019
devhawk
approved these changes
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most collection methods return a pair of iterators, but
MethodDef::Params()returns a const vector.Fix to make it act like the others for consistency. Otherwise, consumers have to write a range specialization for this one case.