Skip to content

Python/WinRT - snake_casing and other changes#253

Merged
devhawk merged 113 commits into
masterfrom
devhawk/pyoverhaul
Apr 1, 2019
Merged

Python/WinRT - snake_casing and other changes#253
devhawk merged 113 commits into
masterfrom
devhawk/pyoverhaul

Conversation

@devhawk

@devhawk devhawk commented Mar 28, 2019

Copy link
Copy Markdown
Contributor
  • UPPER_SNAKE_CASE enum values
  • lower_snake_case methods and properties of projected types
  • fold try catch blocks into trycatch_invoker template
  • generate type aliases in py::wrapper namespace for more readable code
  • generate projected paremeterized types in py::proj and py::impl namespaces instead of name mangling
  • better naming + return value lifetime management in generated delegate wrappers
  • create_python_type / register_python_type functions to eliminate repeated code from module_exec functions
  • remove /debug linker flag from setup.py
  • lots of internal structure improvements

As always, reviewers can see the generated code changes in the the https://github.com/devhawk/pywinrt-output repo. The https://github.com/devhawk/pywinrt-output/tree/overhaul branch contains the changes assosiated with this PR

@devhawk devhawk requested review from Scottj1s, kennykerr and zooba March 28, 2019 18:49
@devhawk devhawk changed the title Python/WinRT - Python/WinRT - snake_casing and other changes Mar 28, 2019

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, based on the Python code in this PR

Comment thread src/test/python/complete_winml_tutorial.py Outdated
Comment thread src/test/python/loader_native.py
Comment thread src/test/python/testcollections.py
@devhawk devhawk force-pushed the devhawk/pyoverhaul branch from c5ef186 to 4533282 Compare March 29, 2019 17:42
Comment thread src/test/python/CMakeLists.txt
Comment thread src/test/python/complete_winml_tutorial.py
Comment thread src/test/python/complete_winml_tutorial.py
Comment thread src/test/python/complete_winml_tutorial.py
Comment thread src/test/python/complete_winml_tutorial.py
Comment thread src/tool/python/code_writers.h Outdated
Comment thread src/tool/python/code_writers.h Outdated
Comment thread src/tool/python/code_writers.h

@kennykerr kennykerr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is just way too big to adequately review, especially since CodeFlow doesn't work with so many commits. The GitHub view is just not conducive to large PRs.

@kennykerr

Copy link
Copy Markdown
Contributor

This PR is just way too big to adequately review, especially since CodeFlow doesn't work with so many commits. The GitHub view is just not conducive to large PRs.

@jonwis

jonwis commented Apr 1, 2019

Copy link
Copy Markdown
Member

This PR is just way too big to adequately review, especially since CodeFlow doesn't work with so many commits. The GitHub view is just not conducive to large PRs.

Maybe create an intermediate branch between master and this one, then stage PRs into it, and then one final PR into master?

@devhawk devhawk merged commit 3cf03af into master Apr 1, 2019
@devhawk devhawk deleted the devhawk/pyoverhaul branch April 3, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants