Python/WinRT - snake_casing and other changes#253
Merged
Conversation
added 30 commits
March 6, 2019 13:58
zooba
approved these changes
Mar 28, 2019
zooba
left a comment
Member
There was a problem hiding this comment.
Looks good, based on the Python code in this PR
added 3 commits
March 28, 2019 15:13
c5ef186 to
4533282
Compare
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
kennykerr
reviewed
Apr 1, 2019
Contributor
|
This PR is just way too big to adequately review, especially since CodeFlow doesn't work with so many commits. The GitHub view is just not conducive to large PRs. |
Member
Maybe create an intermediate branch between master and this one, then stage PRs into it, and then one final PR into master? |
kennykerr
approved these changes
Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As always, reviewers can see the generated code changes in the the https://github.com/devhawk/pywinrt-output repo. The https://github.com/devhawk/pywinrt-output/tree/overhaul branch contains the changes assosiated with this PR