Add output messages to debug visualizer, tied to natvis diagnostics level (VS16)#284
Merged
Conversation
kennykerr
reviewed
Apr 4, 2019
| // and add to the database dynamically. RoGetMetaDataFile looks for types in the current process | ||
| // so cannot be called directly. | ||
| void load_type_winmd(WCHAR const* processPath, std::string runtimeTypeName) | ||
| void LoadMetadata(DkmProcess* process, WCHAR const* processPath, std::string typeName) |
kennykerr
reviewed
Apr 4, 2019
| { | ||
| // If something goes wrong, just fail to display object/property. Don't take down VS. | ||
| NatvisDiagnostic(pVisualizedExpression, | ||
| L"Exception in cppwinrt_visualizer::GetChildren", NatvisDiagnosticLevel::Error, to_hresult()); |
kennykerr
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved an intermittent issue with winrt::hstring not visualizing due to missing COMBase!HSTRING__ symbol
Added copious diagnostic output to help with any remaining failures
fixes #280, #281