Fix type order stability in C++/WinRT headers#287
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
devhawk
as code owners
Scottj1s
approved these changes
Apr 5, 2019
DefaultRyan
reviewed
Apr 5, 2019
|
|
||
| struct depends_compare | ||
| { | ||
| bool operator()(TypeDef const& left, TypeDef const& right) const |
Contributor
Author
There was a problem hiding this comment.
The trouble is that the TypeDef's TypeName and TypeNamespace members are not noexcept so any error retrieving those values would not propagate to a console error message but would instead crash the compiler.
DefaultRyan
approved these changes
Apr 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type declaration order can become unpredictable, leading to headers changing when they shouldn't. This can cause PCH files to recompile unnecessarily.