Devhawk/buildexp#290
Merged
Merged
Conversation
devhawk
commented
Apr 5, 2019
devhawk
commented
Contributor
- remove cmake_minimum_required declarations from all CMakeLists.txt files except top level
- set cmake policy CMP0076 (fixes Building with VS 2019 Preview 2 introduces a lot more cmake noise #147)
- add vsdevcmd-build.cmd windows script that invokes build.cmd from inside a vsdevcmd prompt
devhawk
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s,
dunhor and
kennykerr
as code owners
Contributor
Author
|
Note, Azure Pipelines hosted images are now running recent enough versions of VS2017/2019 to retire the windows container based pipelines. That change will happen sometime after this PR is approved and merged. Example Azure Pipelines build using vsdevcmd-build: https://dev.azure.com/msft-xlang/public/_build/results?buildId=1374 |
kennykerr
approved these changes
Apr 8, 2019
# Conflicts: # src/tool/idl/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.