Remove need for "winrt/coroutine.h" in C++/WinRT 2.0#330
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
devhawk
as code owners
Scottj1s
approved these changes
Apr 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the rollout of C++/WinRT 2.0 has been largely without incident, some friction was introduced by the need to include a distinct header for coroutine support. Given how central coroutine support is to the C++/WinRT library, it makes sense to take this complication out and simply include coroutine support automatically whenever the appropriate namespace headers have been included. This change is only possible now that #321 allowed namespace additions to be injected in the top-level headers.
The popular thread pool helpers are rolled into winrt/base.h and are thus available everywhere as before. A new thread_pool awaitable type also been added to support private pools. Tests have been added to ensure that just the appropriate namespace headers are required. A pragma message has also been added to the now unecessary winrt/coroutine.h header to indicate that it will be removed in future.