Improved error message to help diagnose invalid winmd files #351
Merged
Conversation
Member
|
Nice. The other place where this sort of thing frequently seems to comes up is when trying to resolve base types. Any chance of adding an improved diagnostic there as well? |
DefaultRyan
approved these changes
Apr 24, 2019
Contributor
Author
|
Thanks Ryan, send me the repro steps for that scenario I can certainly add something to help diagnose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small targeted improvement to the diagnostics produced by
cppwinrt.exeto help apply the blame accurately when encountering types in a winmd that use non-WinRT types in an ABI context. For example, given this invalid C++/CX code (that sadly compiles):The cppwinrt compiler now produces a more helpful diagnostic pinpointing the source of the problem:
Given a large winmd with hundreds of types, this can make a world of difference.