Isolate fast forwarder support into standalone header for more general use#397
Merged
Conversation
Scottj1s
requested review from
BenJKuhn,
DefaultRyan,
devhawk and
kennykerr
as code owners
kennykerr
approved these changes
May 9, 2019
BenJKuhn
reviewed
May 9, 2019
| @@ -1,3 +1,13 @@ | |||
| #include <cstddef> | |||
| #include <atomic> | |||
Contributor
There was a problem hiding this comment.
is std::atomic safe for non-throwing code?
Contributor
There was a problem hiding this comment.
Yes, it just compiles down to the various intrinsics and is explicitly noexcept.
Contributor
There was a problem hiding this comment.
ideally would be good to add a test case for this from the repo validating usage of just this header with /Eh-
BenJKuhn
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.