Fast ABI forwarder optimizations#406
Merged
Merged
Conversation
Scottj1s
requested review from
BenJKuhn,
DefaultRyan,
devhawk and
kennykerr
as code owners
Member
Author
|
Discussed with VS team the potential for ABI breaking changes between toolset versions of lib.exe and link.exe, and was assured there is no risk. |
kennykerr
approved these changes
May 15, 2019
Member
|
Might want to look into that failed Windows build. Seems due to a dependency on the 142 toolset? |
DefaultRyan
approved these changes
May 15, 2019
Member
Author
Yes, thanks! |
BenJKuhn
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves some bloat issues related to fast ABI:
For components:
Shrank x64 thunks from 32 to 16 bytes by removing a 6 byte padding (the thunk code itself is only 12 bytes).
For clients:
There is no easy way to implement /Gy-like behavior (function-level linking, or “COMDAT packaging”) in assembler, which is required for /OPT:REF to discard unneeded thunks. To address this, the nuget now includes a lib instead.