Add rules file containing RootNamespace property editor#422
Merged
Conversation
This property is used by the default item templates to populate the namespace of newly generated IDL files. I have no clue why this isn't provided by vcxproj itself.
Member
|
This is a really powerful project extensibility mechanism I didn't know about (and which I intend to use, thanks!) But I'm not sure I understand the problem. When you create a new C++/WinRT item (from template, such as ViewModel), then the namespace is populated with the project's: Where are you seeing that not be the case? By adding the ability to override the project's rootnamespace property at any time, we open the possibility for all kinds of build errors. |
Contributor
|
Scott just showed me what this looks like in Visual Studio - very nifty! |
Member
|
Discussing with Kenny, and in favor of this change, thanks! |
Scottj1s
approved these changes
May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property is used by the default item templates to populate the namespace of newly generated IDL files. I have no clue why this isn't already provided by the core C++ project infrastructure, seeing as it is (apparently) not C++/WinRT-specific.