Optimize C++/WinRT fast ABI forwarding to minimize code size#424
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
devhawk
as code owners
Scottj1s
reviewed
May 22, 2019
Scottj1s
reviewed
May 22, 2019
| } | ||
| } | ||
|
|
||
| #undef WINRT_IMPL_NOVTABLE |
Member
There was a problem hiding this comment.
naming convention change is fine, lets use pragma push/pop for macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update ensures that the fast_forward.h header is sized to content, meaning that the resulting forwarding vtable is only as big as the largest fast ABI vtable in the component. Developers can still override WINRT_FAST_ABI_SIZE if needed to handle multiple libs and assertions are in place to ensure that these values are always aligned.