C++/WinRT single_threaded_observable_vector now supports IInspectable automatically#449
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
devhawk
as code owners
BenJKuhn
approved these changes
May 30, 2019
BenJKuhn
left a comment
BenJKuhn
left a comment
Contributor
There was a problem hiding this comment.
Nice work with deferred boxing. Any concerns around expected behavior of boxed element identity?
Contributor
Author
|
Thanks! I don't think there's a concern since Xaml already does copious amounts of boxing/unboxing and the underlying boxing mechanics continues to rely on the implementation provided by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
single_threaded_observable_vector<T>()helper function creates an implementation ofIObservableVector<T>and ifTis notIInspectablethen the resulting object will now also implementIObservableVector<IInspectable>. Observable collections are predominantly used for Xaml binding and the Xaml framework requiresIObservableVector<IInspectable>in order to support binding.And every time I work on collections I always end up with way more test code than shipping code...
I have also confirmed that this works beautifully with Xaml binding.