Use get_category consistently in cppwinrt implementation#452
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
devhawk
as code owners
Contributor
|
There are a bunch of useful neta reader helpers spread across cppwinrt, pywinrt and other projects. get_category seems like another such useful helper. Can we start a "meta_reader contrib" file in library to host these and stop duplicating effort across tools? |
devhawk
approved these changes
May 31, 2019
Contributor
Author
|
Yes, we should definitely keep an eye out for redundant helpers and fold them into the xlang library if they are widely applicable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some time back I introduced the
get_categoryhelper to solve some more challenging parameter categorization issues in the cppwinrt compiler. This made the clunkycan_take_ownership_of_return_typeandwrap_abihelper functions redundant. This update just removes those functions and makes use ofget_categorythroughout. Internal bug #21214501.