add winrt::com_ptr, winrt::param::hstring, winrt::...::IUnknown to .natvis file#477
Merged
Conversation
jonwis
approved these changes
Jun 12, 2019
Member
Yes, been thinking the visualizer should support not just projected types but implementations too. Unfortunately, that's all static natvis (not dynamic via GetRuntimeClassName, etc). So it would be a fairly hefty natvis file, but they do parse fairly quickly. |
Scottj1s
approved these changes
Jun 12, 2019
ChrisGuzak
changed the title
Member
|
winrt::param::hstring is fine |
Member
|
Consider adding some documentation on the wiki about how to use msvc's link.exe -natvis option. Makes debugging magically better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is minor but aids debugging.
I really want to fix winrt::implements too. I was able to improve WRL::RuntimeClass and think I might be able to apply that to this case but I need to play with it more. Scott, if you have ideas on that let me know.