Use ResolveProjectReferences target and limit WinMDs passed to mdmerge.exe#491
Conversation
|
Seems like I have some whitespace changes that I will revert. |
|
@kennykerr probably want to wait for @Scottj1s to take a look before merging. |
|
Yes, Scott will be back in a week. This can wait. |
|
Lots of tweaks (thanks!) - how has this been tested? Both VS 2017 and 2019, with various p2p reference scenarios? |
|
I tested this on the YourPhone solution with 34 projects. It has:
|
|
Great - thank you! One remaining test scenario - dynamic projects with multiple winmds (see comment) In reply to: 509732892 [](ancestors = 509732892) |
c8a25ee to
2ea117e
Compare
|
great test collateral - just need to point to props/targets in repo instead of using last published Nuget. I was just discussing with Kenny scripting the creation of something like this from project templates (also testing the VSIX). Seems doable with dotnet CLI, which can create projects, references, etc - but we can do that later. |
0679bfc to
9702ada
Compare
…inmds as references for mdmerge instead of using a wilcard for the project output folders.
a2f1819 to
0585d74
Compare
|
Looks Good! |
This PR fixes a few issues with the way CppWinRT handles project references, that prevent certain project types from not being included in the reference projection or causes duplicate type errors because the winmd ends up being referenced twice:
To fix those problems I made two changes.