Improved GetMany test for C++/WinRT#499
Merged
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan and
Scottj1s
as code owners
DefaultRyan
reviewed
Jul 8, 2019
| }; | ||
|
|
||
| return make<list>(std::move(values)); | ||
| auto v = single_threaded_vector<T>(std::move(values)); |
Member
There was a problem hiding this comment.
Add the ability to do this for a container that is definitely not random-access, like std::list.
Contributor
Author
There was a problem hiding this comment.
That's what generator_container ensures as it only offers an IIterator<T>. I initially used std::list alone and while that ensures that random access is not available, it doesn't ensure that multiple traversals aren't employed. Here a vector is used merely for convenience to create the container that the forward-only WinRT iterator is backed by.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the test to use an iterator that may only be advanced once, ensuring the GetMany complexity optimization is actually enforced with this test. This updates #497