Make lack of weak-ref support more debuggable in C++/WinRT#502
Merged
Conversation
kennykerr
requested review from
BenJKuhn,
DefaultRyan and
Scottj1s
as code owners
kennykerr
changed the title
BenJKuhn
approved these changes
Jul 9, 2019
DefaultRyan
approved these changes
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few OS APIs (mostly just
Windows.UI.Composition) still don't support weak references and this causes a lot of pain for developers who don't realize why something so fundamental fails for a small subset of APIs. The problem is hard to diagnose for developers because it is reported as anE_NOINTERFACEexception that quickly propagates away from the source of the problem. It is a coding bug (and not a recoverable error) to useauto_revoke/weak_refwith an object that does not support weak references. This change makes such a failure far easier to debug by turning it into an immediate crash.