Add support for PE32+ (64-bit) winmd parsing, to re-enable managed assemblies#530
Merged
Conversation
Scottj1s
requested review from
BenJKuhn,
DefaultRyan and
kennykerr
as code owners
DefaultRyan
approved these changes
Jul 19, 2019
|
|
||
| impl::image_section_header const* sections{}; | ||
| uint32_t com_virtual_address{}; | ||
| if (pe.OptionalHeader.Magic == 0x10B) // PE32 |
Member
There was a problem hiding this comment.
Prefer to define these two values as constants. The metadata writer should share the value.
Member
Author
There was a problem hiding this comment.
Yes, should do that for the DOS magic number too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #527