Automatically determine the mdmerge merge depth based on the RootNamespace.#538
Merged
Merged
Conversation
jlaanstra
requested review from
BenJKuhn,
DefaultRyan,
Scottj1s and
kennykerr
as code owners
jlaanstra
commented
Jul 24, 2019
Scottj1s
approved these changes
Jul 24, 2019
Scottj1s
left a comment
Scottj1s
left a comment
Member
There was a problem hiding this comment.
oh yes - property sheet too, thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new functionality to the build targets to automatically determine the merge depth based on the RootNamespace following the namespace syntax as explained here: https://docs.microsoft.com/en-us/uwp/winrt-cref/winmd-files.
All existing mechanism to set the merge depth take precendence over this new mechanism.
Example
Imagine a project with RootNamespace set to "Namespace1". Within this project there are some classes in Namespace1 and some classes in Namespace1.SubNamespace1
Current behavior
Currently this would result in two winmd files and a developer would have to manually set the merge depth to generate a single file.
New behavior
Merge depth would be automatically set to 1 as the RootNamespace has length 1, resulting in a single winmd file.